Add Opcodes and Errors classes in generated Typescript code #1100
Conversation
…Added opcodes class generation. Added ExitCodes map generation.
anton-trunov
changed the title
apparently this is not entirely true :) |
|
|
||
| //Opcodes | ||
| //So user can use them in sandbox tests | ||
| w.append("export abstract class Opcodes {"); |
There was a problem hiding this comment.
TypeScript has enum syntax for this. abstract class implies user should inherit from it to get access to its fields, and that's definitely not the way in a language without multiple inheritance.
| @@ -272,58 +303,66 @@ export function writeTypescript( | |||
|
|
|||
| if (init) { | |||
| w.append( | |||
| `static async init(${writeArguments(init.args).join(", ")}) {`, | |||
| `static async init<T extends ${abi.name}>(` + | |||
| `this: new (address: Address, init?: { code: Cell, data: Cell }) => T,` + | |||
There was a problem hiding this comment.
This kind of types is meant to type legacy JS code, not to write or generate novel code.
| w.append(`const ${abi.name}_errorMessages: { [key: string]: number } = {`); | ||
| w.inIndent(() => { | ||
| if (abi.errors) { | ||
| Object.entries(abi.errors).forEach(([k, abiError]) => { |
There was a problem hiding this comment.
for (const [k, abiError] of abi.errors) would be more readable, concise and performant.
There was a problem hiding this comment.
@verytactical there is a few of instances of Object.entries(foo).forEach(([k, v]) ... in the codebase. Could you please open an issue to refactor those?
| if (abi.errors) { | ||
| Object.entries(abi.errors).forEach(([k, abiError]) => { | ||
| const escapedMessage = abiError.message.replaceAll('"', '\\"'); | ||
| w.append(` "${escapedMessage}": ${k},`); |
There was a problem hiding this comment.
This is an indent that doesn't take .inIndent() state in consideration.
|
Let's move on with this PR please. @Shvandre can we see some tests for the changes? |
|
Decided to put this into the backlog. Will return to this after Typescript codegen refactoring |
Issue
Closes #1033 .
Checklist
docs/and made the build locally